Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix bootstrap on windows #746

Merged
merged 3 commits into from
Jul 6, 2020
Merged

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Jul 6, 2020

I had to do 2 fixes to make yarn bootstrap work

  1. Git should have files saved as LF so os.EOL doesn't work. Switching to just "\n" works.
  2. cp does not exists on windows, cpy-cli can fix this. (happy to use any other package)

@ghost
Copy link

ghost commented Jul 6, 2020

CLA assistant check
All CLA requirements met.

@orta
Copy link
Contributor

orta commented Jul 6, 2020

Cool! I wonder what's up with the yarn install - re-running

@wardpeet
Copy link
Contributor Author

wardpeet commented Jul 6, 2020

@orta, I see that I committed a change with my prettier config. Should I revert? Are you ok with adding husky, prettier perhaps?

I'm happy to do the work

@orta
Copy link
Contributor

orta commented Jul 6, 2020

Yeah, it's fine - that's the right prettier config, I think sometimes my editor gets confused and ships the default

@orta
Copy link
Contributor

orta commented Jul 6, 2020

( I already have that stuff set up, but it only triggers for me )

@orta
Copy link
Contributor

orta commented Jul 6, 2020

There we go, working fine - it was mainly just me pushing to master during work on #130 (comment)

@orta orta merged commit 08f3b1c into microsoft:v2 Jul 6, 2020
@wardpeet wardpeet deleted the fix/windows-build branch July 6, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants