Fixing bug: Unsafe HTML constructed from library input #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navya9singh
added
the
deploy-preview
jakebailey
reviewed
Jan 28, 2025
navya9singh
added
deploy-preview
|
I'd recommend switching the text for that button to use ( But no idea what's going on with that dependency, Gatsby normally bundles deps, maybe it makes a networking request inside its codebase? ) |
|
Yeah, the code I am suggesting is: const versionButton = document.querySelectorAll("#versions > a").item(0)
versionButton.textContent = "v" + sandbox.ts.version + " "
const caret = document.createElement("spam")
caret.classList.add("caret")
versionButton.appendChild(caret)or similar |
jakebailey
reviewed
Jan 29, 2025
packages/playground/package.json
Outdated
| @@ -17,7 +17,8 @@ | |||
| "dependencies": { | |||
| "@typescript/playground-worker": "workspace:*", | |||
| "@typescript/sandbox": "workspace:*", | |||
| "esbuild": "^0.17.8" | |||
| "esbuild": "^0.17.8", | |||
| "striptags": "^3.2.0" | |||
There was a problem hiding this comment.
The changes to package.json / pnpm-lock can now be reverted.
navya9singh
added
deploy-preview
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-plant-05c166c10-3312.centralus.5.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes https://liquid.microsoft.com/codeql/issues/71221708-d80d-49f5-b177-1b536b3b3e22 where unsafe HTML was constructed from library input. Fix is according to the recommendation provided by https://liquid.microsoft.com/Web/Object/Read/ScanningToolWarnings/Requirements/CodeQL.SM03892#Zguide.