Make elementToAppend take priority over domID for sandbox configs
#2886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
approved these changes
Jul 18, 2023
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Seems fine to me, though I'm assuming this is a part of a published package, in which case I'm holding off those kinds of PRs a little until I can... figure out how exactly to bump and publish these packages correctly.
Contributor
|
Merges to |
4 tasks
Member
|
With bump versions with #2904 to minimize the waiting within the current infrastructure. |
jakebailey
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2885.