Return a promise from ATA #2694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does a couple of things: - More ergonomic - Know when a specific type request has completed. (Current finish event is insufficient, doesn't tell you which request is completed and is never called if the provided source code has no imports).
Contributor
|
Seems reasonable to me, I'd recommend also bumping the package json version so when the PR is merged it will also release 👍🏻 |
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Author
Done 👍 |
jakebailey
approved these changes
Jul 24, 2023
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
LGTM but will merge/release this with the other PRs that require package publishes.
4 tasks
Member
|
With bump versions with #2904 to minimize the waiting within the current infrastructure. |
jakebailey
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a couple of things: