fix CustomElementConstructor - https://github.com/microsoft/TypeScript/issues/36965 #833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jogibear9988
changed the title
sandersn
approved these changes
Mar 17, 2020
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Looks good, but doesn't update baselines -- we want to take this for 3.9 since it's a 3.8 regression, so I'll update the baselines.
|
|
orta
added a commit
that referenced
this pull request
Mar 20, 2020
orta
pushed a commit
that referenced
this pull request
Mar 20, 2020
Recrate #833 from scratch to avoid CLA issues
Contributor
|
Deprecated by #838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes microsoft/TypeScript#36965