Skip to content

Add cloneNode overloads #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandersn merged 3 commits into from
Mar 17, 2020
Merged

Add cloneNode overloads #811

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4988fca
Add cloneNode overloads
IllusionMH Dec 9, 2019
574ec17
Merge branch 'master' into clonenode-overloads
sandersn Mar 17, 2020
c92bbaa
update baselines
sandersn Mar 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6599,7 +6599,7 @@ interface HTMLElementEventMap extends ElementEventMap, GlobalEventHandlersEventM
}

/** Any HTML element. Some elements directly implement this interface, while others implement it via an interface that inherits it. */
interface HTMLElement extends Element, DocumentAndElementEventHandlers, ElementCSSInlineStyle, ElementContentEditable, GlobalEventHandlers, HTMLOrSVGElement {
interface HTMLElement extends Element, DocumentAndElementEventHandlers, ElementCSSInlineStyle, ElementCSSInlineStyle, ElementContentEditable, GlobalEventHandlers, HTMLOrSVGElement {
accessKey: string;
readonly accessKeyLabel: string;
autocapitalize: string;
Expand Down Expand Up @@ -7579,7 +7579,7 @@ declare var HTMLMarqueeElement: {
};

interface HTMLMediaElementEventMap extends HTMLElementEventMap {
"encrypted": MediaEncryptedEvent;
"encrypted": Event;
"waitingforkey": Event;
}

Expand Down Expand Up @@ -7636,7 +7636,7 @@ interface HTMLMediaElement extends HTMLElement {
* Gets the current network activity for the element.
*/
readonly networkState: number;
onencrypted: ((this: HTMLMediaElement, ev: MediaEncryptedEvent) => any) | null;
onencrypted: ((this: HTMLMediaElement, ev: Event) => any) | null;
onwaitingforkey: ((this: HTMLMediaElement, ev: Event) => any) | null;
/**
* Gets a flag that specifies whether playback is paused.
Expand Down Expand Up @@ -19365,14 +19365,12 @@ interface HTMLElementTagNameMap {
"area": HTMLAreaElement;
"article": HTMLElement;
"aside": HTMLElement;
"audio": HTMLAudioElement;
"b": HTMLElement;
"base": HTMLBaseElement;
"basefont": HTMLBaseFontElement;
"bdi": HTMLElement;
"bdo": HTMLElement;
"blockquote": HTMLQuoteElement;
"body": HTMLBodyElement;
"br": HTMLBRElement;
"button": HTMLButtonElement;
"canvas": HTMLCanvasElement;
Expand Down Expand Up @@ -19402,12 +19400,6 @@ interface HTMLElementTagNameMap {
"form": HTMLFormElement;
"frame": HTMLFrameElement;
"frameset": HTMLFrameSetElement;
"h1": HTMLHeadingElement;
"h2": HTMLHeadingElement;
"h3": HTMLHeadingElement;
"h4": HTMLHeadingElement;
"h5": HTMLHeadingElement;
"h6": HTMLHeadingElement;
"head": HTMLHeadElement;
"header": HTMLElement;
"hgroup": HTMLElement;
Expand Down Expand Up @@ -19471,11 +19463,9 @@ interface HTMLElementTagNameMap {
"time": HTMLTimeElement;
"title": HTMLTitleElement;
"tr": HTMLTableRowElement;
"track": HTMLTrackElement;
"u": HTMLElement;
"ul": HTMLUListElement;
"var": HTMLElement;
"video": HTMLVideoElement;
"wbr": HTMLElement;
}

Expand Down
14 changes: 12 additions & 2 deletions inputfiles/addedTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2239,7 +2239,7 @@
"cloneNode": {
"name": "cloneNode",
"override-signatures": [
"cloneNode(deep?: boolean): HTMLDialogElement"
"cloneNode(deep?: boolean): HTMLVideoElement"
Copy link
Contributor Author

@IllusionMH IllusionMH Mar 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where this one came from probably from conflict.
Thanks for fixing this one.

]
}
}
Expand All @@ -2250,7 +2250,17 @@
{
"name": "dialog"
}
]
],
"methods": {
"method": {
"cloneNode": {
"name": "cloneNode",
"override-signatures": [
"cloneNode(deep?: boolean): HTMLDialogElement"
]
}
}
}
},
"EXT_blend_minmax": {
"override-exposed": "Window Worker"
Expand Down