Update CSSOM View #590
Merged
Update CSSOM View #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
approved these changes
Oct 29, 2018
There was a problem hiding this comment.
This change is OK, but I'd like to see a general solution to too-small unions causing interned-union name pollution. Right now anybody that makes an alias "auto" | "smooth" will see the name ScrollBehavior, not the name of their alias.
The probability of collision of 2-element aliases is too high for me. Maybe we can inline 2-element enums when generating from IDL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
instantwhich was an alias ofauto: w3c/csswg-drafts#3074Adds(TS already has this.)screenLeft/screenTopwhich have been de-facto standard: w3c/csswg-drafts#2669