Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix#6418 #46

Merged
merged 3 commits into from
Jan 18, 2016
Merged

fix#6418 #46

merged 3 commits into from
Jan 18, 2016

Conversation

YuichiNukiyama
Copy link
Contributor

This request fix window.open return
type
issue.

This request fix  [window.open return
type](microsoft/TypeScript#6418) issue.
@msftclas
Copy link

Hi @YuichiNukiyama, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

@YuichiNukiyama, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@mhegazy
Copy link
Contributor

mhegazy commented Jan 13, 2016

👍

fetch latest branch.
@zhengbli
Copy link
Contributor

👍 should be able to merge once the conflicts are resolved.

resolve conflict
zhengbli added a commit that referenced this pull request Jan 18, 2016
@zhengbli zhengbli merged commit 1e76d8b into microsoft:master Jan 18, 2016
@YuichiNukiyama YuichiNukiyama deleted the fix6418 branch January 18, 2016 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

window.open return type
4 participants