Skip to content

Conversation

@plantain-00
Copy link
Contributor

@msftclas
Copy link

Hi @plantain-00, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@mhegazy
Copy link
Contributor

mhegazy commented Jan 12, 2016

👍

1 similar comment
@zhengbli
Copy link
Contributor

👍

zhengbli added a commit that referenced this pull request Jan 13, 2016
@zhengbli zhengbli merged commit b9b0cee into microsoft:master Jan 13, 2016
@elisee
Copy link
Contributor

elisee commented May 6, 2016

I believe the function signature is wrong, toBlob() is async and takes a callback and media type according to https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/toBlob

@mhegazy
Copy link
Contributor

mhegazy commented May 6, 2016

@elisee do you mind filling a new issue for this?

@elisee
Copy link
Contributor

elisee commented May 6, 2016

@mhegazy sure, done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants