Skip to content

To fix #2583 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
plantain-00 wants to merge 8 commits into from
Closed

To fix #2583 #44

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
79d3feb
To fix #2583
plantain-00 Jan 12, 2016
ae04994
Merge pull request #2 from Microsoft/master
plantain-00 Jan 26, 2016
782e389
Merge branch 'master' into i2583
plantain-00 Jan 26, 2016
859643d
try to change properties of URL
plantain-00 Jan 26, 2016
6c4a4a2
Merge branch 'master' into i2583
plantain-00 Jan 26, 2016
99de366
accept baseline after merging
plantain-00 Jan 26, 2016
c4094af
add inteface URLConstructor
plantain-00 Jan 26, 2016
8661795
try another way
plantain-00 Jan 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10754,10 +10754,21 @@ declare var UIEvent: {
}

interface URL {
createObjectURL(object: any, options?: ObjectURLOptions): string;
revokeObjectURL(url: string): void;
hash: number;
search: number;
pathname: number;
port: number;
hostname: number;
host: number;
password: number;
username: number;
protocol: number;
origin: number;
href: number;
}

declare var URL: {
}
declare var URL: URL;

interface UnviewableContentIdentifiedEvent extends NavigationEventWithReferrer {
mediaType: string;
Expand Down
66 changes: 66 additions & 0 deletions inputfiles/addedTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,72 @@
"name": "selectedOptions",
"type": "HTMLCollection"
},
{
"kind": "property",
"interface": "URL",
"name": "hash",
"type": "number"
},
{
"kind": "property",
"interface": "URL",
"name": "search",
"type": "number"
},
{
"kind": "property",
"interface": "URL",
"name": "pathname",
"type": "number"
},
{
"kind": "property",
"interface": "URL",
"name": "port",
"type": "number"
},
{
"kind": "property",
"interface": "URL",
"name": "hostname",
"type": "number"
},
{
"kind": "property",
"interface": "URL",
"name": "host",
"type": "number"
},
{
"kind": "property",
"interface": "URL",
"name": "password",
"type": "number"
},
{
"kind": "property",
"interface": "URL",
"name": "username",
"type": "number"
},
{
"kind": "property",
"interface": "URL",
"name": "protocol",
"type": "number"
},
{
"kind": "property",
"interface": "URL",
"name": "origin",
"type": "number"
},
{
"kind": "property",
"interface": "URL",
"name": "href",
"type": "number"
},
{
"kind": "method",
"interface": "HTMLCanvasElement",
Expand Down
10 changes: 10 additions & 0 deletions inputfiles/removedTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,16 @@
"interface": "HTMLElement",
"name": "contains"
},
{
"kind": "method",
"interface": "URL",
"name": "createObjectURL"
Copy link
Contributor

@mhegazy mhegazy Jan 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should be added on a new interface URLConstructor, and var URL: URLConstructor

},
{
"kind": "method",
"interface": "URL",
"name": "revokeObjectURL"
},
{
"kind": "method",
"interface": "StorageEvent",
Expand Down