Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alt attribute from HTMLObjectElement interface #356

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

benbraou
Copy link
Contributor

alt is not part of the HTML Standard for HTMLObjectElement

Fixes microsoft/TypeScript#21386

@mhegazy
Copy link
Contributor

mhegazy commented Jan 24, 2018

@benbraou
Copy link
Contributor Author

Done. Thanks!

@mhegazy
Copy link
Contributor

mhegazy commented Jan 24, 2018

u also need to update the baselines after removing the comment.

alt is not part of the HTML Standard for HTMLObjectElement

Fixes microsoft/TypeScript#21386
@benbraou
Copy link
Contributor Author

Done. Thanks for taking time to review :) I see now how comments.json and removedTypes.json play together to generate the baseline

@benbraou
Copy link
Contributor Author

@mhegazy does it make sense to you to update the section inREADME

Add missing elements to inputfiles/addedTypes.json, overriding elements to inputfiles/overridingTypes.json, or elements to remove to inputfiles/removedTypes.json.

with an indication that that may also imply to add/remove comments from inputfiles/comments.json (depending on the matching types that have been added or removed)

I can do a PR for that

@mhegazy mhegazy merged commit 9e63191 into microsoft:master Jan 29, 2018
@benbraou benbraou deleted the ts-issue21386 branch January 31, 2018 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants