[iOS] fix voiceover duplicates for labels #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaChingMSFT
added
HCL-AdaptiveCards
A11yWCAG
A11ySev2
HCL-AdaptiveCards-iOS
A11yRT
JoshuaChingMSFT
changed the title
GabrielMedAlv
approved these changes
Feb 1, 2024
JoshuaChingMSFT
force-pushed
the
joching/ios-a11y-label-fix
branch
from
fb7e0b1
to
776a3db
Compare
JoshuaChingMSFT
force-pushed
the
joching/ios-a11y-label-fix
branch
from
776a3db
to
aaeb05a
Compare
GabrielMedAlv
approved these changes
Feb 1, 2024
hggz
reviewed
Feb 2, 2024
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRTextBlockRenderer.mm
Show resolved
Hide resolved
VikrantSingh01
approved these changes
Feb 5, 2024
hggz
approved these changes
Feb 5, 2024
MengliElmendorf137
approved these changes
Feb 5, 2024
rahulpinjani1
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes Issue: #24
Description
A11Y voiceover announces the same piece of content twice when the accessibility label and accessibility value are the same.
The fix is to clear the accessibility value if accessibility label and accessibility value are the same.
How Verified
A11Y Inspector Before:
A11Y Inspector After:
