[Android + iOS]: Allow configuration of AC Fluent icon CDN paths for different environments #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyAbhishek
approved these changes
Sep 5, 2024
wyAbhishek
changed the title
…aptiveCards-Mobile into singhmanp/fluentIconCdnPathsForDifferentEnv
wyAbhishek
changed the title
prpatwa
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Android changes
Currently, Fluent icon assets for AC are served from this unique CDN path:
https://res-1.cdn.office.net/assets/fluentui-react-icons/2.0.226/,
But The base path for this CDN should actually be different based on the environment. This PR adds another method in IFeatureFlagResolver to fetch the ECS settings as String for a key. This method will be used to fetch the FluentIconCdnRoot and FluentIconCdnPath from ECS and use those to create a Cdn URL to fetch and render fluent icons.
The host will register its featureFlagResolver and will implement the getEcsSettingAsString method to fetch the values from the ECS.
iOS changes
Currently, Fluent icon assets for AC are served from this unique CDN path:
https://res-1.cdn.office.net/assets/fluentui-react-icons/2.0.226/,
But The base path for this CDN should actually be different based on the environment. This PR uses FeatureFlagResolver to fetch root CDN URL from host application.
if host doesn't provide value for flag "fluentIconCdnURL", then we will use existing default url.
Sample Card