Fix build issue with cocoapod and Xcode15 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielMedAlv
approved these changes
Jun 10, 2024
wyAbhishek
changed the title
hggz
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are addressing two issues with this PR:
1: There was an issue with build cocoapod :include of non-modular header inside framework module. This PR intends to fix this issue.
We have moved ACRRatingInputDataSource.h file to private headers to avoid this issue.
2: SVGKit dependency fails with error: "Umbrella header for module 'SVGKit' does not include header xxx".
This issue if fixed by moving dependency to latest version of SVGKit. The consumer of Adaptive card sdk can point to any commit of SVGKit as needed.