conditional enablement for Action.submit & Action.execute #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyAbhishek
reviewed
Apr 29, 2024
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRIBaseInputHandler.h
Outdated
Show resolved
Hide resolved
wyAbhishek
reviewed
Apr 29, 2024
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRTextInputHandler.h
Outdated
Show resolved
Hide resolved
wyAbhishek
reviewed
Apr 29, 2024
GabrielMedAlv
approved these changes
Apr 29, 2024
hggz
reviewed
Apr 30, 2024
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRActionExecuteRenderer.mm
Outdated
Show resolved
Hide resolved
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRActionExecuteRenderer.mm
Outdated
Show resolved
Hide resolved
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRActionSubmitRenderer.mm
Outdated
Show resolved
Hide resolved
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRActionSubmitRenderer.mm
Show resolved
Hide resolved
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRActionSubmitRenderer.mm
Outdated
Show resolved
Hide resolved
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRTextInputHandler.mm
Outdated
Show resolved
Hide resolved
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRDateTextField.mm
Show resolved
Hide resolved
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRInputNumberRenderer.mm
Show resolved
Hide resolved
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRInputRenderer.mm
Show resolved
Hide resolved
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRToggleInputDataSource.mm
Show resolved
Hide resolved
hggz
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new boolean property called conditionallyEnabled which will be applicable to only Action.submit and Action.execute button. Button with this property set as true will be disabled until there is valid input in at least one of the required fields. If not passed default value is true for this and it will get ignored in case button isEnabled is passed as false.
Design doc : https://microsoft-my.sharepoint-df.com/:w:/p/dclaux/ERDxhgUQZalDhhF-dZ-JqcQB0lmaQzlk6olTX1X8Ic8RBw?wdOrigin=TEAMS-MAGLEV.p2p_ns.rwc&wdExp=TEAMS-TREATMENT&wdhostclicktime=1714022774737&web=1
Sample Card
If appropriate, please include a link to a card in one of the samples directories that can be used to validate this change. This can be an existing card or a card added with this PR.
WIP:
2. Need to make same change for Action.execute button, will add after thorough testing with Action.submit button.
https://github.com/microsoft/AdaptiveCards-Mobile/assets/85880757/f1e069b4-e6b5-41e5-8d04-9fa444baf06c