[iOS]Add rounded corner and border support for some elements #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyAbhishek
commented
Apr 9, 2024
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRColumnRenderer.mm
Outdated
Show resolved
Hide resolved
GabrielMedAlv
approved these changes
Apr 10, 2024
|
Looks good to me. I don't seem to be able to approve though. IU may not have write access to this repo. |
ardlank
reviewed
Apr 17, 2024
ardlank
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Review the shared changes and looks good to me. @GabrielMedAlv please review the iOS changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to add support for showBorder and roundedCorners properties.
showBorder Property
If value of this property is true, then we will show 1pt border. Border colour will be same as container's style, taken from host config. We will be supporting showing borders on the following elements:
Borders are already supported on the Table element. Default value is false.
roundedCorners Property
If value of this property is true then we will show rounded corner for element. Corner radius is 5pt.
We will be supporting rounded corners on the following elements:
We are adding rounded corner support for Image element also. But it will be enabled through existing ImageStyle property. So, style of Image can be Default, Person and now RoundedCorners.
Sample Card
Added some mock elements with showBorder and roundedCorner properties set to true.
Adding some screenshots for these changes below:
