Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging UploadUrl in log file #255

Merged
merged 8 commits into from
Jun 11, 2024
Merged

Fix logging UploadUrl in log file #255

merged 8 commits into from
Jun 11, 2024

Conversation

joseartrivera
Copy link
Contributor

Fix logging UploadUrl in log file

HowardWolosky
HowardWolosky requested changes Jun 7, 2024
View reviewed changes
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you not change to Write-Host. Try the suggestion I offer instead.
Additionally, you need to rev the version number, update the CHANGELOG, and then you'll want to deploy an update to PowerShellGallery.

HowardWolosky
HowardWolosky requested changes Jun 7, 2024
View reviewed changes
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax was slightly off in what you were writing such that it wouldn't have worked for the user.

HowardWolosky
HowardWolosky requested changes Jun 7, 2024
View reviewed changes
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just about there. I noticed that you're calling the wrong method to get the submission object for the Flight and IAP scenario

HowardWolosky
HowardWolosky approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@joseartrivera joseartrivera merged commit f2668ee into microsoft:master Jun 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HowardWolosky HowardWolosky HowardWolosky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joseartrivera @HowardWolosky