Removing binary dependencies for telemetry #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverse engineers the REST API for Application Insights so that we no longer need to download / depend on the 3 .dll files that were necessary to use the Application Insights .NET SDK. This is directly benefitting from the work that was done for PowerShellForGitHub (see microsoft/PowerShellForGitHub#186) > This is a re-implementation of the similar change done in the master > branch (for v1). See microsoft#201
HowardWolosky
added a commit
to HowardWolosky/StoreBroker
that referenced
this pull request
Aug 24, 2020
When microsoft#202 brought over the raw telemetry work from PowerShellForGitHub, it erroneously left in a `Get-GitHubConfiguration` call which should have been removed.
HowardWolosky
added a commit
that referenced
this pull request
Aug 24, 2020
When #202 brought over the raw telemetry work from PowerShellForGitHub, it erroneously left in a `Get-GitHubConfiguration` call which should have been removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverse engineers the REST API for Application Insights so that we no longer need to download / depend on the 3 .dll files that were necessary to use the Application Insights .NET SDK.
This is directly benefitting from the work that was done for PowerShellForGitHub (see microsoft/PowerShellForGitHub#186)