Skip to content

Commit

Permalink
Load assemblies into common appdomain/loadcontext (#178)
Browse files Browse the repository at this point in the history 
.NET Core implementation of `Assembly.Load` creates a new [AssemblyLoadContext](https://github.com/dotnet/coreclr/blob/master/Documentation/design-docs/assemblyloadcontext.md), isolating assemblies and ultimately resulting in dependency load related failures (e.g. #177).

This change loads Azure Storage assemblies into the default AppDomain or AssemblyLoadContext via `Assembly.LoadFrom`.

Fixes #177
  • Loading branch information
@riverar
riverar authored Aug 24, 2020
1 parent be3c438 commit bb0b4a0
Showing 1 changed file with 8 additions and 20 deletions.
28 changes: 8 additions & 20 deletions StoreBroker/StoreIngestionApi.psm1
View file
Original file line number Diff line number Diff line change
Expand Up @@ -829,11 +829,8 @@ function Set-SubmissionPackage
[System.Net.ServicePointManager]::DefaultConnectionLimit = [Environment]::ProcessorCount * 8
[System.Net.ServicePointManager]::Expect100Continue = $false

$bytes = [System.IO.File]::ReadAllBytes($azureStorageDll)
[System.Reflection.Assembly]::Load($bytes) | Out-Null

$bytes = [System.IO.File]::ReadAllBytes($azureStorageDataMovementDll)
[System.Reflection.Assembly]::Load($bytes) | Out-Null
[System.Reflection.Assembly]::LoadFrom($azureStorageDll) | Out-Null
[System.Reflection.Assembly]::LoadFrom($azureStorageDataMovementDll) | Out-Null

$uri = New-Object -TypeName System.Uri -ArgumentList $UploadUrl
$cloudBlockBlob = New-Object -TypeName Microsoft.WindowsAzure.Storage.Blob.CloudBlockBlob -ArgumentList $uri
Expand All @@ -858,11 +855,8 @@ function Set-SubmissionPackage
[System.Net.ServicePointManager]::DefaultConnectionLimit = [Environment]::ProcessorCount * 8
[System.Net.ServicePointManager]::Expect100Continue = $false

$bytes = [System.IO.File]::ReadAllBytes($AzureStorageDll)
[System.Reflection.Assembly]::Load($bytes) | Out-Null

$bytes = [System.IO.File]::ReadAllBytes($AzureStorageDataMovementDll)
[System.Reflection.Assembly]::Load($bytes) | Out-Null
[System.Reflection.Assembly]::LoadFrom($AzureStorageDll) | Out-Null
[System.Reflection.Assembly]::LoadFrom($AzureStorageDataMovementDll) | Out-Null

$uri = New-Object -TypeName System.Uri -ArgumentList $UploadUrl
$cloudBlockBlob = New-Object -TypeName Microsoft.WindowsAzure.Storage.Blob.CloudBlockBlob -ArgumentList $uri
Expand Down Expand Up @@ -1025,11 +1019,8 @@ function Get-SubmissionPackage
[System.Net.ServicePointManager]::DefaultConnectionLimit = [Environment]::ProcessorCount * 8
[System.Net.ServicePointManager]::Expect100Continue = $false

$bytes = [System.IO.File]::ReadAllBytes($azureStorageDll)
[System.Reflection.Assembly]::Load($bytes) | Out-Null

$bytes = [System.IO.File]::ReadAllBytes($azureStorageDataMovementDll)
[System.Reflection.Assembly]::Load($bytes) | Out-Null
[System.Reflection.Assembly]::LoadFrom($azureStorageDll) | Out-Null
[System.Reflection.Assembly]::LoadFrom($azureStorageDataMovementDll) | Out-Null

$uri = New-Object -TypeName System.Uri -ArgumentList $UploadUrl
$cloudBlockBlob = New-Object -TypeName Microsoft.WindowsAzure.Storage.Blob.CloudBlockBlob -ArgumentList $uri
Expand All @@ -1054,11 +1045,8 @@ function Get-SubmissionPackage
[System.Net.ServicePointManager]::DefaultConnectionLimit = [Environment]::ProcessorCount * 8
[System.Net.ServicePointManager]::Expect100Continue = $false

$bytes = [System.IO.File]::ReadAllBytes($AzureStorageDll)
[System.Reflection.Assembly]::Load($bytes) | Out-Null

$bytes = [System.IO.File]::ReadAllBytes($AzureStorageDataMovementDll)
[System.Reflection.Assembly]::Load($bytes) | Out-Null
[System.Reflection.Assembly]::LoadFrom($AzureStorageDll) | Out-Null
[System.Reflection.Assembly]::LoadFrom($AzureStorageDataMovementDll) | Out-Null

$uri = New-Object -TypeName System.Uri -ArgumentList $UploadUrl
$cloudBlockBlob = New-Object -TypeName Microsoft.WindowsAzure.Storage.Blob.CloudBlockBlob -ArgumentList $uri
Expand Down

0 comments on commit bb0b4a0

Please sign in to comment.