CR feedback

microsoft · Nov 10, 2017 · 6669d32 · 6669d32
1 parent 4890c17
commit 6669d32
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 10 deletions.
diff --git a/StoreBroker/Helpers.ps1 b/StoreBroker/Helpers.ps1
@@ -46,7 +46,7 @@ function Initialize-HelpersGlobalVariables
         $documentsFolder = [System.Environment]::GetFolderPath('MyDocuments')
         if (-not [System.String]::IsNullOrEmpty($documentsFolder))
         {
-            $global:SBLogPath = (Join-Path -Path $documentsFolder -ChildPath 'StoreBroker.log')
+            $global:SBLogPath = Join-Path -Path $documentsFolder -ChildPath 'StoreBroker.log'
         }
         else
         {

diff --git a/StoreBroker/StoreIngestionApplicationApi.ps1 b/StoreBroker/StoreIngestionApplicationApi.ps1
@@ -1082,10 +1082,10 @@ function Update-ApplicationSubmission
         $output = @()
         $output += "The config file used to generate this submission did not have an AppId defined in it."
         $output += "The AppId entry in the config helps ensure that payloads are not submitted to the wrong application."
-        $output += "Please update your app's StoreBroker config file by adding an ""appId"" property with"
-        $output += "your app's AppId to the ""appSubmission"" section.  If you're unclear on what change"
+        $output += "Please update your app's StoreBroker config file by adding an `"appId`" property with"
+        $output += "your app's AppId to the `"appSubmission`" section.  If you're unclear on what change"
         $output += "needs to be done, you can re-generate your config file using"
-        $output += "   ""New-StoreBrokerConfigFile -AppId $AppId -Path ""$configPath"""
+        $output += "   New-StoreBrokerConfigFile -AppId $AppId -Path `"$configPath`""
         $output += "and then diff the new config file against your current one to see the requested appId change."
         Write-Log $($output -join [Environment]::NewLine) -Level Warning
     }

diff --git a/StoreBroker/StoreIngestionFlightingApi.ps1 b/StoreBroker/StoreIngestionFlightingApi.ps1
@@ -1288,9 +1288,10 @@ function Update-ApplicationFlightSubmission
         $output = @()
         $output += "The config file used to generate this submission did not have an AppId defined in it."
         $output += "The AppId entry in the config helps ensure that payloads are not submitted to the wrong application."
-        $output += "Please update your app's StoreBroker config file by adding an ""appId"" property with"
-        $output += "your app's AppId to the ""appSubmission"" section.  If you're unclear on what change"
-        $output += "needs to be done, you can re-generate your config file using ""New-PackageToolConfigFile -AppId $AppId -Path ""$configPath"""
+        $output += "Please update your app's StoreBroker config file by adding an `"appId`" property with"
+        $output += "your app's AppId to the `"appSubmission`" section.  If you're unclear on what change"
+        $output += "needs to be done, you can re-generate your config file using"
+        $output += "   New-PackageToolConfigFile -AppId $AppId -Path `"$configPath`""
         $output += "and then diff the new config file against your current one to see the requested appId change."
         Write-Log $($output -join [Environment]::NewLine) -Level Warning
     }

diff --git a/StoreBroker/StoreIngestionIapApi.ps1 b/StoreBroker/StoreIngestionIapApi.ps1
@@ -1315,10 +1315,10 @@ function Update-InAppProductSubmission
         $output = @()
         $output += "The config file used to generate this submission did not have an IapId defined in it."
         $output += "The IapId entry in the config helps ensure that payloads are not submitted to the wrong In-App Product."
-        $output += "Please update your app's StoreBroker config file by adding an ""iapId"" property with"
-        $output += "your IAP's IapId to the ""iapSubmission"" section.  If you're unclear on what change"
+        $output += "Please update your app's StoreBroker config file by adding an `"iapId`" property with"
+        $output += "your IAP's IapId to the `"iapSubmission`" section.  If you're unclear on what change"
         $output += "needs to be done, you can re-generate your config file using"
-        $output += "   ""New-StoreBrokerInAppProductConfigFile -IapId $IapId -Path ""$configPath"""
+        $output += "   New-StoreBrokerInAppProductConfigFile -IapId $IapId -Path `"$configPath`""
         $output += "and then diff the new config file against your current one to see the requested iapId change."
         Write-Log $($output -join [Environment]::NewLine) -Level Warning
     }