Skip to content

Fix non-inline random_bool_vector in benchmarks #5742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2025
+29 −33
Merged

Fix non-inline random_bool_vector in benchmarks #5742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
579012e
Fuse functions
AlexGuteniev Sep 26, 2025
fa045e1
Optimize bool branch too for consistency
AlexGuteniev Sep 26, 2025
2f3b5e3
All shall love mt19937_64 and despair.
StephanTLavavej Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions benchmarks/inc/utility.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,30 +7,26 @@
#include <cstddef>
#include <memory>
#include <random>
#include <type_traits>
#include <vector>

template <class Contained, template <class> class Alloc = std::allocator>
std::vector<Contained, Alloc<Contained>> random_vector(size_t n) {
std::mt19937_64 prng;

std::vector<Contained, Alloc<Contained>> res(n);
std::mt19937_64 prng;

if constexpr (std::is_same_v<Contained, bool>) {
std::generate(res.begin(), res.end(), [&prng] { return static_cast<bool>(prng() & 1); });
} else {
// Here, the type Contained can be char, int, aggregate<Data>, or non_trivial<Data> where Data is char or int.
// (aggregate<Data> and non_trivial<Data> are defined in udt.hpp.)
// static_cast<Contained> silences truncation warnings when Contained is directly char or int,
// but is insufficient for aggregate<Data> or non_trivial<Data>.
#pragma warning(push)
#pragma warning(disable : 4244) // warning C4244: conversion from 'uint64_t' to 'Data', possible loss of data
std::generate(res.begin(), res.end(), [&prng] { return static_cast<Contained>(prng()); });
std::generate(res.begin(), res.end(), [&prng] { return static_cast<Contained>(prng()); });
#pragma warning(pop)
}

return res;
}

std::vector<bool> random_bool_vector(const size_t size) {
std::mt19937 gen;
std::bernoulli_distribution dist{0.5};
std::vector<bool> result(size);
std::generate(result.begin(), result.end(), [&] { return dist(gen); });
return result;
}
14 changes: 7 additions & 7 deletions benchmarks/src/vector_bool_copy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ using namespace std;

void copy_block_aligned(benchmark::State& state) {
const auto size = static_cast<size_t>(state.range(0));
vector<bool> source = random_bool_vector(size);
vector<bool> source = random_vector<bool>(size);
vector<bool> dest(size, false);

for (auto _ : state) {
Expand All @@ -26,7 +26,7 @@ void copy_block_aligned(benchmark::State& state) {

void copy_source_misaligned(benchmark::State& state) {
const auto size = static_cast<size_t>(state.range(0));
vector<bool> source = random_bool_vector(size);
vector<bool> source = random_vector<bool>(size);
vector<bool> dest(size, false);

for (auto _ : state) {
Expand All @@ -38,7 +38,7 @@ void copy_source_misaligned(benchmark::State& state) {

void copy_dest_misaligned(benchmark::State& state) {
const auto size = static_cast<size_t>(state.range(0));
vector<bool> source = random_bool_vector(size);
vector<bool> source = random_vector<bool>(size);
vector<bool> dest(size, false);

for (auto _ : state) {
Expand All @@ -51,7 +51,7 @@ void copy_dest_misaligned(benchmark::State& state) {
// Special benchmark for matching char alignment
void copy_matching_alignment(benchmark::State& state) {
const auto size = static_cast<size_t>(state.range(0));
vector<bool> source = random_bool_vector(size);
vector<bool> source = random_vector<bool>(size);
vector<bool> dest(size, false);

for (auto _ : state) {
Expand All @@ -63,7 +63,7 @@ void copy_matching_alignment(benchmark::State& state) {

// Special benchmarks for single block corner case
void copy_both_single_blocks(benchmark::State& state) {
vector<bool> source = random_bool_vector(50);
vector<bool> source = random_vector<bool>(50);
vector<bool> dest(50, false);

const size_t length = 20;
Expand All @@ -75,7 +75,7 @@ void copy_both_single_blocks(benchmark::State& state) {
}

void copy_source_single_block(benchmark::State& state) {
vector<bool> source = random_bool_vector(50);
vector<bool> source = random_vector<bool>(50);
vector<bool> dest(50, false);

const size_t length = 20;
Expand All @@ -87,7 +87,7 @@ void copy_source_single_block(benchmark::State& state) {
}

void copy_dest_single_block(benchmark::State& state) {
vector<bool> source = random_bool_vector(50);
vector<bool> source = random_vector<bool>(50);
vector<bool> dest(50, false);

const size_t length = 20;
Expand Down
14 changes: 7 additions & 7 deletions benchmarks/src/vector_bool_copy_n.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ using namespace std;

void copy_n_block_aligned(benchmark::State& state) {
const auto size = static_cast<size_t>(state.range(0));
vector<bool> source = random_bool_vector(size);
vector<bool> source = random_vector<bool>(size);
vector<bool> dest(size, false);

for (auto _ : state) {
Expand All @@ -26,7 +26,7 @@ void copy_n_block_aligned(benchmark::State& state) {

void copy_n_source_misaligned(benchmark::State& state) {
const auto size = static_cast<size_t>(state.range(0));
vector<bool> source = random_bool_vector(size);
vector<bool> source = random_vector<bool>(size);
vector<bool> dest(size, false);

for (auto _ : state) {
Expand All @@ -38,7 +38,7 @@ void copy_n_source_misaligned(benchmark::State& state) {

void copy_n_dest_misaligned(benchmark::State& state) {
const auto size = static_cast<size_t>(state.range(0));
vector<bool> source = random_bool_vector(size);
vector<bool> source = random_vector<bool>(size);
vector<bool> dest(size, false);

for (auto _ : state) {
Expand All @@ -51,7 +51,7 @@ void copy_n_dest_misaligned(benchmark::State& state) {
// Special benchmark for matching char alignment
void copy_n_matching_alignment(benchmark::State& state) {
const auto size = static_cast<size_t>(state.range(0));
vector<bool> source = random_bool_vector(size);
vector<bool> source = random_vector<bool>(size);
vector<bool> dest(size, false);

for (auto _ : state) {
Expand All @@ -63,7 +63,7 @@ void copy_n_matching_alignment(benchmark::State& state) {

// Special benchmarks for single block corner case
void copy_n_both_single_blocks(benchmark::State& state) {
vector<bool> source = random_bool_vector(50);
vector<bool> source = random_vector<bool>(50);
vector<bool> dest(50, false);

const size_t length = 20;
Expand All @@ -75,7 +75,7 @@ void copy_n_both_single_blocks(benchmark::State& state) {
}

void copy_n_source_single_block(benchmark::State& state) {
vector<bool> source = random_bool_vector(50);
vector<bool> source = random_vector<bool>(50);
vector<bool> dest(50, false);

const size_t length = 20;
Expand All @@ -87,7 +87,7 @@ void copy_n_source_single_block(benchmark::State& state) {
}

void copy_n_dest_single_block(benchmark::State& state) {
vector<bool> source = random_bool_vector(50);
vector<bool> source = random_vector<bool>(50);
vector<bool> dest(50, false);

const size_t length = 20;
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/src/vector_bool_count.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ using namespace std;

void count_aligned(benchmark::State& state) {
const auto size = static_cast<size_t>(state.range(0));
vector<bool> v = random_bool_vector(size);
vector<bool> v = random_vector<bool>(size);

bool b = false;

Expand Down
14 changes: 7 additions & 7 deletions benchmarks/src/vector_bool_move.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ using namespace std;

void move_block_aligned(benchmark::State& state) {
const auto size = static_cast<size_t>(state.range(0));
vector<bool> source = random_bool_vector(size);
vector<bool> source = random_vector<bool>(size);
vector<bool> dest(size, false);

for (auto _ : state) {
Expand All @@ -26,7 +26,7 @@ void move_block_aligned(benchmark::State& state) {

void move_source_misaligned(benchmark::State& state) {
const auto size = static_cast<size_t>(state.range(0));
vector<bool> source = random_bool_vector(size);
vector<bool> source = random_vector<bool>(size);
vector<bool> dest(size, false);

for (auto _ : state) {
Expand All @@ -38,7 +38,7 @@ void move_source_misaligned(benchmark::State& state) {

void move_dest_misaligned(benchmark::State& state) {
const auto size = static_cast<size_t>(state.range(0));
vector<bool> source = random_bool_vector(size);
vector<bool> source = random_vector<bool>(size);
vector<bool> dest(size, false);

for (auto _ : state) {
Expand All @@ -51,7 +51,7 @@ void move_dest_misaligned(benchmark::State& state) {
// Special benchmark for matching char alignment
void move_matching_alignment(benchmark::State& state) {
const auto size = static_cast<size_t>(state.range(0));
vector<bool> source = random_bool_vector(size);
vector<bool> source = random_vector<bool>(size);
vector<bool> dest(size, false);

for (auto _ : state) {
Expand All @@ -63,7 +63,7 @@ void move_matching_alignment(benchmark::State& state) {

// Special benchmarks for single block corner case
void move_both_single_blocks(benchmark::State& state) {
vector<bool> source = random_bool_vector(50);
vector<bool> source = random_vector<bool>(50);
vector<bool> dest(50, false);

const size_t length = 20;
Expand All @@ -75,7 +75,7 @@ void move_both_single_blocks(benchmark::State& state) {
}

void move_source_single_block(benchmark::State& state) {
vector<bool> source = random_bool_vector(50);
vector<bool> source = random_vector<bool>(50);
vector<bool> dest(50, false);

const size_t length = 20;
Expand All @@ -87,7 +87,7 @@ void move_source_single_block(benchmark::State& state) {
}

void move_dest_single_block(benchmark::State& state) {
vector<bool> source = random_bool_vector(50);
vector<bool> source = random_vector<bool>(50);
vector<bool> dest(50, false);

const size_t length = 20;
Expand Down