Skip to content

Update llvm-project #5688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 26, 2025
Merged

Update llvm-project #5688

merged 13 commits into from
Aug 26, 2025

Conversation

StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Aug 20, 2025 •
edited
Loading

@StephanTLavavej StephanTLavavej requested a review from a team as a code owner August 20, 2025 22:18
@StephanTLavavej StephanTLavavej added the test Related to test code label Aug 20, 2025
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Aug 20, 2025
davidmrdavid
davidmrdavid reviewed Aug 21, 2025
View reviewed changes
davidmrdavid
davidmrdavid approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the clean commits, as usual.

@StephanTLavavej
Copy link
Member Author

You're welcome! I was able to merge my nodiscard PR so I removed those skips.

@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Aug 21, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Aug 25, 2025
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

frederick-vs-ja
frederick-vs-ja reviewed Aug 26, 2025
View reviewed changes
@StephanTLavavej
Mark C++26 tests as FAIL for the internal harness, and more.
296388d 
Mention 'std-at-least-c++26'.
Record frederick-vs-ja's analysis of string.capacity/deallocate_size.pass.cpp.
Mark Apple test as SKIPPED for the internal harness.
@StephanTLavavej
Update llvm-project.
fe06179
@StephanTLavavej StephanTLavavej merged commit 37d575e into microsoft:main Aug 26, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Aug 26, 2025
@StephanTLavavej StephanTLavavej deleted the update-llvm branch August 26, 2025 21:12
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmrdavid davidmrdavid davidmrdavid approved these changes

+1 more reviewer

@frederick-vs-ja frederick-vs-ja frederick-vs-ja left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
test Related to test code
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StephanTLavavej @davidmrdavid @frederick-vs-ja