Skip to content

<xloctime>: Silence CodeQL warning SM03231 about leap year arithmetic #5625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

<xloctime>: Silence CodeQL warning SM03231 about leap year arithmetic #5625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions stl/inc/xloctime
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,11 +418,13 @@ protected:
if (!(_Res & ios_base::failbit)) {
if (_Digits_read <= 2) {
if (_Ans < 69) {
// CodeQL [SM03231] This is parsing tm_year (years since 1900); leap years are irrelevant.
_Pt->tm_year = _Ans + 100; // [00, 68] parsed as [2000, 2068]
} else if (_Ans < 100) {
_Pt->tm_year = _Ans; // [69, 99] parsed as [1969, 1999]
}
} else {
// CodeQL [SM03231] This is parsing tm_year (years since 1900); leap years are irrelevant.
_Pt->tm_year = _Ans - 1900; // parsed literally
}
}
Expand Down Expand Up @@ -456,6 +458,7 @@ protected:
case 'C':
_State |= _Getint(_First, _Last, 0, 99, _Ans, _Ctype_fac);
if (!(_State & ios_base::failbit)) {
// CodeQL [SM03231] This is parsing tm_year (years since 1900); leap years are irrelevant.
_Pt->tm_year = _Ans * 100 - 1900; // convert to century
}

Expand Down Expand Up @@ -549,15 +552,21 @@ protected:
case 'y':
_State |= _Getint(_First, _Last, 0, 99, _Ans, _Ctype_fac);
if (!(_State & ios_base::failbit)) {
_Pt->tm_year = _Ans < 69 ? _Ans + 100 : _Ans;
if (_Ans < 69) {
// CodeQL [SM03231] This is parsing tm_year (years since 1900); leap years are irrelevant.
_Pt->tm_year = _Ans + 100; // [00, 68] parsed as [2000, 2068]
} else {
_Pt->tm_year = _Ans; // [69, 99] parsed as [1969, 1999]
}
}

break;

case 'Y':
_State |= _Getint(_First, _Last, 0, 9999, _Ans, _Ctype_fac);
if (!(_State & ios_base::failbit)) {
_Pt->tm_year = _Ans - 1900;
// CodeQL [SM03231] This is parsing tm_year (years since 1900); leap years are irrelevant.
_Pt->tm_year = _Ans - 1900; // parsed literally
}
break;

Expand Down