-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Implement P3223R2 Making istream::ignore() Less Surprising
#5604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
std::istream::ignore Less Surprisingstd::istream::ignore() Less Surprising
std::istream::ignore() Less Surprisingistream::ignore() Less Surprising
|
@frederick-vs-ja (This is not a review. Just a couple of questions.) Was the paper voted in as DR? I guess not. My reading of the Standard is that resolving the ambiguity is not required is that so? |
I guess not, either. But according to the paper issue I think it should be treated as a DR.
Yes. In this PR the ambiguity is resolved "by accident", which is a consequence of backporting. I don't think the ambiguity resolution is disallowed, either. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
🐱 😸 🐈 |
As a Defect Report against old standard modes. Fixes #5618.
As a result of DR-backing P3223R2, the new overload is templated, and thus this PR happens to "constrain the new overload to prevent ambiguities" and keeps
in.ignore(100, -1L)well-formed.