-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Make benchmarks compiling in clang-cl #5533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make benchmarks compiling in clang-cl #5533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I wonder why changes elsewhere are relevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frederick-vs-ja the rest are just const that can potentially be optimized, so DoNotOptimize
is deprecated
Thanks! I cleaned up pre-existing weirdness in |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for making the benchmark directory more portable and conformant! 😻 🚢 🚀 |
Towards #5479
Most of the time it is warning about deprecated
benchmark::DoNotOptimize
for constants.🏗️ Build steps
Build STL as usual:
Then add
-DCMAKE_CXX_COMPILER=clang-cl
to benchmark build: