Skip to content

Conversation

@frederick-vs-ja
Copy link
Contributor

Tested with llvm/llvm-project@0b2ab11.

  • Fixes narrowing conversion in std::inplace_merge due to assumption that the every wrapped iterator type has the same difference type as the unwrapped version.
  • Removes uses of optional-for-sequence-containers cbegin/cend.
  • Properly constrains constructors and deduction guides of flat_(multi)set.

Many libcxx tests seem to be buggy - e.g. some are testing uses with underlying containers that lack assign or insert_range, some are test moving comparators, some are testing bogus emplace member functions.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner May 2, 2025 15:25
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews May 2, 2025
@StephanTLavavej StephanTLavavej added bug Something isn't working flat_meow C++23 container adaptors labels May 2, 2025
@StephanTLavavej StephanTLavavej merged commit d2e3e14 into microsoft:feature/flat_map May 2, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Initial Review to Done in STL Code Reviews May 2, 2025
@StephanTLavavej
Copy link
Member

Awesome, thank you! 😻

@frederick-vs-ja frederick-vs-ja deleted the libcxx-flat-set-test-fixes-1 branch May 3, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working flat_meow C++23 container adaptors

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants