Skip to content

Conversation

@AlexGuteniev
Copy link
Contributor

Fixes #5345

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner March 19, 2025 19:55
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Mar 19, 2025
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Mar 19, 2025
@StephanTLavavej StephanTLavavej changed the title Handle aligned vector<bool> in constexpr properly Handle aligned vector<bool> in constexpr copy() properly Mar 19, 2025
@StephanTLavavej StephanTLavavej self-assigned this Mar 19, 2025
@StephanTLavavej

This comment was marked as resolved.

@AlexGuteniev

This comment was marked as resolved.

@StephanTLavavej
Copy link
Member

Thanks! 😻 I pushed minor changes, the most significant being an expansion of test coverage.

There's an interesting libcxx failure that looks like a Clang constexpr bug - I reduced it enough to be confident that it's not a bug in our product code.

@StephanTLavavej StephanTLavavej removed their assignment Apr 19, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Apr 19, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Apr 22, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 094ce6a into microsoft:main Apr 22, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Apr 22, 2025
@StephanTLavavej
Copy link
Member

Thanks for aligning the stars! 🌃 🌠 🔭

@AlexGuteniev AlexGuteniev deleted the boo branch April 22, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

<vector>: _Copy_vbool() mishandles vector<bool>s of size 32 and 64, revealed by constexpr Clang

2 participants