Implement P3323R1 Forbid atomic<cv T>, Specify atomic_ref<cv T>
#5213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
force-pushed
the
p3323r1
branch
from
feb38df to
c673b29
Compare
frederick-vs-ja
force-pushed
the
p3323r1
branch
from
c673b29 to
9070ced
Compare
frederick-vs-ja
commented
Jan 8, 2025
StephanTLavavej
approved these changes
Jan 10, 2025
|
Thanks! 😻 I pushed a moderate number of changes, please double-check. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
approved these changes
Jan 13, 2025
|
I had to push a commit to work around an internal chk compiler assertion VSO-2343282 "C1XX assertion 'If lookup found RDSymbol before it should find something this time, too' affecting STL atomic_ref test". |
☢️ ❌ ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5147. Fixes #4719.
Blocked libcxx test(s):
std/atomics/atomics.ref/member_types.compile.pass.cpp