-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolset update: VS 2022 17.13 Preview 2, F32as_v6 #5186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been fixed internally, so we don't need to mirror this to the Perl script.
StephanTLavavej
added
infrastructure
Related to repository automation
uncharted
Excluded from the Status Chart
labels
Dec 12, 2024
StephanTLavavej
force-pushed
the
fast-sku
branch
from
December 12, 2024 18:41
75e234c
to
0f83485
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
CaseyCarter
approved these changes
Dec 12, 2024
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
This was referenced Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Changelog
⚙️ Commits
conversion_for_direct_reference_binding_possible
".cpfe.dll!make_coroutine_result_expression
with C++23<generator>
test".src\vctools\crt\github\tests\std\tests\Dev09_056375_locale_cleanup
failed due to ERROR: AddressSanitizer: access-violation on unknown address"./shallowScan
to work around VSO-2293247 "/Zc:preprocessor
does not terminate macro definitions properly".C:
and rename directories to avoid any possible collisions.D:
storage drive.-DiskControllerType 'NVMe'
toNew-AzVMConfig
might not be strictly necessary, but passing theDiskControllerTypes
feature toNew-AzGalleryImageDefinition
is absolutely necessary. Otherwise, 1ES Hosted Pools provisioning will completely and mysteriously fail.STL-ASan-CI passed.
🚀 Speedup vs. 🤑 Cost
This significantly accelerates the CI. To do proper science, I cleanly compared this toolset update with varying SKUs:
Standard_D32ads_v5
.Standard_F32as_v6
.Previously, the x64 shards took an average of 731 seconds (12m 11s). Now they take an average of 507 seconds (8m 27s), which is a 1.442x speedup. Unsurprisingly, this SKU is more expensive per-hour (1.326x), but the speedup means that this is effectively cheaper to run.