<ranges>: Fix regression with ranges::to for ADL-only begin/end
#5173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
force-pushed
the
lwg-4016-regression
branch
from
88e5d0d to
8624d1e
Compare
StephanTLavavej
approved these changes
Dec 9, 2024
hewillk
reviewed
Dec 10, 2024
Co-authored-by: Hewill Kang <[email protected]>
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
approved these changes
Dec 12, 2024
|
Thanks for fixing this conformance bug in one of the STL's shortest-named functions! 🛠️ 🐞 2️⃣ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4539, the
ranges::for_eachcall in the resolution of LWG-4016 was "manually inlined" to reduce inclusion dependency. However, the inlining was not always correct, because builtin-in range-formay just stop and fail when a deleted memberbegin/endfunction is encountered, whilerangesCPOs continue to consider ADL-foundbegin/end.As a result, we should still use
ranges::begin/ranges::end.Fixes #5172.