-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<regex>
: Small cleanups
#5058
<regex>
: Small cleanups
#5058
Conversation
Thanks! 😸 FYI @CaseyCarter I pushed minor changes after you approved. Also, in case it wasn't just a typo - note that "simply" is an adverb, while "simplify" is a verb. |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
I had to push an additional commit to fix regressions found by our Perennial test suite. See the cited Standardese for const-default-constructible and https://godbolt.org/z/GeWYxf37f . |
Thanks for cleaning up one of our dustiest headers! 🌬️ 🧹 🪄 |
std::char_traits
andsub_match
.const
to someoperator()
. A (non-static, non-explicit-parameter)operator()
withoutconst
usually implies the status of the function can be modified, which is not the case for the touched functors.= default;
and default member initializers for some classes.Maybe in a future PR: Moving some function bodies into class bodies. Separation doesn't seem necessary to me, but the change is a bit large.