Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update _MSVC_STL_UPDATE to October 2024 #4994

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Update _MSVC_STL_UPDATE to October 2024 #4994

merged 1 commit into from
Oct 12, 2024

Conversation

DIlkhush00
Copy link
Contributor

resolves #4988

@DIlkhush00 DIlkhush00 requested a review from a team as a code owner September 30, 2024 14:21
@DIlkhush00
Copy link
Contributor Author

DIlkhush00 commented Sep 30, 2024 •
edited
Loading

hey @StephanTLavavej , My #4989 PR got closed due to the deletion of my forked STL repo. So I have opened a new PR with the same changes as my last PR. I hope that's okay 🙂.

@CaseyCarter CaseyCarter added the enhancement Something can be improved label Sep 30, 2024
@CaseyCarter
Copy link
Contributor

From #4989 😸:

Perfect, thank you! 😻

We merge PRs to our GitHub and MSVC-internal repos simultaneously in a semi-manual process, batched up to save time. Your PR will be part of the next batch. I'll post updates here as I prepare your PR for merging!

@StephanTLavavej StephanTLavavej mentioned this pull request Sep 30, 2024
Open
@StephanTLavavej StephanTLavavej self-assigned this Oct 11, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit cae8af0 into microsoft:main Oct 12, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

Thanks for updating this version macro and congratulations on your first microsoft/STL commit! 🎉 🚀 😺

This change is expected to ship in VS 2022 17.13 Preview 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to October 2024
3 participants
@DIlkhush00 @CaseyCarter @StephanTLavavej