Reduce inclusion for IO stream headers in C++23 #4936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Sep 7, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for noticing this throughput regression and figuring out how to mitigate it! 🚀 🐇 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, I was informed that
<complex>indirectly included<format>(in C++23 mode). In C++23,<ostream>needs almost all contents in<format>due to theprintfunction family, so it's reasonable for<ostream>to include<format>since C++23. However, it doesn't seem necessary for some other IO stream headers and<complex>to indirectly include<format>.Note that
<syncstream>and<iostream>are required to include<ostream>by the Standard, so it's perhaps impossible to reduce inclusion for them. This PR splits a new internal header<__msvc_ostream.hpp>from<ostream>and leaves no any other public header to include the whole<ostream>.<__msvc_ostream.hpp>.