Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolset update: VS 2022 17.11 Preview 2 #4725

Merged
merged 8 commits into from
Jun 18, 2024

Conversation

StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Jun 12, 2024

📜 Changelog

  • Code cleanups:
    • Removed compiler bug workarounds.
  • Infrastructure improvements:
    • Updated dependencies.
      • Updated build compiler to VS 2022 17.11 Preview 2.
      • Updated Python to 3.12.4.

💡 Notes

The internal build compiler still needs to be updated (@MahmoudGSaleh is working on it, but it's a time-consuming process), so we still can't require _MSC_VER 1941.

Similarly, a new WinSDK is available, but the internal build isn't using it yet, so I'm not updating the image or the readme to specify it. (This is updated at a slower pace, so it might not happen for a while.)

STL-ASan-CI passed.

⚙️ Workarounds removed

  • VSO-1913897 DevCom-10508937 "Startup issue when building the static debug STL with ASan enabled"
  • VSO-1985428 "<limits.h> emits warning C4668"
  • VSO-2016422 "EDG hasn't (completely?) implemented CWG-2518 making static_assert(false) usable"
    • Product code still needs this workaround for CUDA 12.4, so I've updated the comment in <type_traits>.
  • VSO-2064546 "EDG ICE when deriving from std::num_get"

@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Jun 12, 2024
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner June 12, 2024 11:30
@StephanTLavavej
Copy link
Member Author

/azp run STL-ASan-CI

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AlexGuteniev
Copy link
Contributor

How can you remove workarounds without updating internal build?

@StephanTLavavej
Copy link
Member Author

That's a good question! (And one that I didn't fully think through before submitting this PR 😹)

In this case I think I'll get away with all of these workaround removals. EDG is updated independently from the checked-in MSVC toolset, and is actually usually a newer version than what's shipping publicly, so the EDG workaround removals should be fine. The <limits.h> workaround removal depends on updated VCRuntime sources that I fixed, which are present in the internal repo (they aren't consumed from the checked-in toolset). So that leaves the ASAN issue, which I think will be okay - the checked-in toolset is used only for the initial build, whereas the tests run with the freshly built compiler. Even though we're building the compiler with ASAN these days (or will shortly, I forget), this bug was specific to the static debug STL, but the compiler doesn't consume the STL statically.

@StephanTLavavej StephanTLavavej self-assigned this Jun 14, 2024
@StephanTLavavej
Copy link
Member Author

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit a1f8a58 into microsoft:main Jun 18, 2024
39 checks passed
@StephanTLavavej StephanTLavavej deleted the vs17.11p2 branch June 18, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to repository automation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants