-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolset update: VS 2022 17.11 Preview 2 #4725
Conversation
…n building the static debug STL with ASan enabled".
…ted CWG-2518 making static_assert(false) usable".
/azp run STL-ASan-CI |
Azure Pipelines successfully started running 1 pipeline(s). |
How can you remove workarounds without updating internal build? |
That's a good question! (And one that I didn't fully think through before submitting this PR 😹) In this case I think I'll get away with all of these workaround removals. EDG is updated independently from the checked-in MSVC toolset, and is actually usually a newer version than what's shipping publicly, so the EDG workaround removals should be fine. The |
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
📜 Changelog
💡 Notes
The internal build compiler still needs to be updated (@MahmoudGSaleh is working on it, but it's a time-consuming process), so we still can't require
_MSC_VER
1941
.Similarly, a new WinSDK is available, but the internal build isn't using it yet, so I'm not updating the image or the readme to specify it. (This is updated at a slower pace, so it might not happen for a while.)
STL-ASan-CI passed.
⚙️ Workarounds removed
<limits.h>
emits warning C4668"static_assert(false)
usable"<type_traits>
.std::num_get
"