Cleanup compiler bug workarounds and their comments#4362

Merged

StephanTLavavej merged 30 commits intomicrosoft:mainfrom StephanTLavavej:workaround-comments

Feb 6, 2024

+149-146

Commits on Feb 2, 2024

Preprocessor FC: Guard an MSVC workaround.
StephanTLavavej
committed
Preprocessor FC: Allow EDG (in addition to Clang) to run test cases that only MSVC has trouble with.
StephanTLavavej
committed
Preprocessor FC: Avoid a hidden "assert bug" scenario.
StephanTLavavej
committed
Preprocessor NFC: Guard with __cpp_lib_is_layout_compatible and __cpp_lib_is_pointer_interconvertible.
StephanTLavavej
committed
Preprocessor NFC: We conventionally use the order defined(__clang__) || defined(__EDG__).
StephanTLavavej
committed
Preprocessor NFC: We conventionally use the order !defined(__clang__) && !defined(__EDG__).
StephanTLavavej
committed
Add missing arrows to a workaround comment.
StephanTLavavej
committed
Add missing arrows to other comments.
StephanTLavavej
committed
Attach TRANSITION comment.
StephanTLavavej
committed
Mark feature-test macro definitions as no workaround.
StephanTLavavej
committed
Pair #else // ^^^ no workaround / workaround vvv with #endif // ^^^ workaround ^^^.
StephanTLavavej
committed
Pair #else // ^^^ workaround / no workaround vvv with #endif // ^^^ no workaround ^^^.
StephanTLavavej
committed
Pair #if !(defined(_DEBUG) && defined(__EDG__)) with #endif // ^^^ no workaround ^^^.
StephanTLavavej
committed
Pair #if !defined(_PREFAST_) && !defined(__EDG__) with #endif // ^^^ no workaround ^^^.
StephanTLavavej
committed
Pair #ifndef __EDG__ with #endif // ^^^ no workaround ^^^.
StephanTLavavej
committed
Pair #ifdef __EDG__ with #endif // ^^^ workaround ^^^.
StephanTLavavej
committed
Pair #if defined(__clang__) || defined(__EDG__) with #endif // ^^^ no workaround ^^^.
StephanTLavavej
committed
Pair #if defined(__clang__) || defined(__EDG__) with #endif // ^^^ workaround ^^^.
StephanTLavavej
committed
Pair #if !defined(__clang__) && !defined(__EDG__) with #endif // ^^^ no workaround ^^^.
StephanTLavavej
committed
Pair #if !defined(__clang__) && !defined(__EDG__) with #endif // ^^^ workaround ^^^.
StephanTLavavej
committed
Pair #ifndef _M_CEE with #endif // ^^^ no workaround ^^^.
StephanTLavavej
committed
Pair #ifndef _M_CEE_PURE with #endif // ^^^ no workaround ^^^.
StephanTLavavej
committed
Pair #ifdef __cplusplus_winrt with #endif // ^^^ workaround ^^^.
StephanTLavavej
committed
Pair #ifndef __clang__ with #endif // ^^^ no workaround ^^^.
StephanTLavavej
committed
Pair #if !(defined(__clang__) && defined(_M_IX86)) with #endif // ^^^ no workaround ^^^.
StephanTLavavej
committed
Pair #ifdef __clang__ with #endif // ^^^ workaround ^^^.
StephanTLavavej
committed
Pair #ifndef __SANITIZE_ADDRESS__ with #endif // ^^^ no workaround ^^^.
StephanTLavavej
committed
Pair defined(_MSVC_EXECUTION_CHARACTER_SET) with #endif // ^^^ no workaround ^^^.
StephanTLavavej
committed

Commits on Feb 4, 2024

Drop <algorithm> comment change to avoid conflicting with GH 4367's removal of that line.
StephanTLavavej
committed

Commits on Feb 6, 2024

Merge branch 'main' into workaround-comments
StephanTLavavej
committed