Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip libc++'s non-Standard ascii tests, reported upstream #4328

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Skip libc++'s non-Standard ascii tests, reported upstream #4328

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e6a67c
Move libc++'s `ascii` tests to "LIKELY BOGUS TESTS"
cpplearner Jan 18, 2024
0d50418
Address Casey's code review feedback.
StephanTLavavej Jan 19, 2024
7ab8023
Created an LLVM PR.
StephanTLavavej Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/libcxx/expected_results.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,6 +712,11 @@ std/iterators/iterator.requirements/iterator.concepts/iterator.concept.random.ac
# Bogus test expects to_address() to SFINAE away for int.
std/utilities/memory/pointer.conversion/to_address_without_pointer_traits.pass.cpp FAIL

# libc++'s "ascii" mode considers every code unit to represent a valid printable narrow character.
# We don't support such a mode.
StephanTLavavej marked this conversation as resolved.
Show resolved Hide resolved
std/utilities/format/format.functions/ascii.pass.cpp FAIL
std/utilities/format/format.functions/escaped_output.ascii.pass.cpp FAIL
StephanTLavavej marked this conversation as resolved.
Show resolved Hide resolved


# *** LIKELY STL BUGS ***
# Not analyzed, likely STL bugs. Various assertions.
Expand Down Expand Up @@ -947,9 +952,6 @@ std/algorithms/alg.modifying.operations/alg.unique/ranges_unique.pass.cpp:1 SKIP
std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.hex.pass.cpp SKIPPED
std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_double.hex.pass.cpp SKIPPED

# Not analyzed. These tests use characters that cannot be represented in legacy character encodings
std/utilities/format/format.functions/ascii.pass.cpp FAIL

# Not analyzed. Failing assert(swaps <= expected).
std/algorithms/alg.modifying.operations/alg.rotate/ranges_rotate.pass.cpp FAIL

Expand Down Expand Up @@ -1029,7 +1031,6 @@ std/ranges/range.adaptors/range.lazy.split/range.lazy.split.inner/iter_swap.pass
std/thread/futures/futures.task/futures.task.members/ctor2.compile.pass.cpp FAIL

# Not analyzed. MSVC emits truncation warnings, Clang fails a runtime assertion.
std/utilities/format/format.functions/escaped_output.ascii.pass.cpp FAIL
std/utilities/format/format.functions/locale-specific_form.pass.cpp FAIL

# Not analyzed.
Expand Down