Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<random>: Fix minor conformance issues #4120

Merged
merged 2 commits into from
Oct 25, 2023
Merged

<random>: Fix minor conformance issues #4120

merged 2 commits into from
Oct 25, 2023

Commits on Oct 23, 2023

  1. Conformance: base_type in <random> is a non-Standard typedef. 

    Remove it outright for Standard `discard_block_engine` (via the new base class `_Discard_block_base`), `independent_bits_engine`, and `shuffle_order_engine`.

For `discard_block`, which is usually the base class for Standard `discard_block_engine`, we can guard the typedef with TR1's availability, and deprecate it. We should then avoid using it ourselves.
    @StephanTLavavej
    StephanTLavavej committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    15a3369 View commit details
    Browse the repository at this point in the history

  2. Conformance: Add _Engine&& constructors to discard_block and `_Di… 

    …scard_block_base`.

`discard_block_engine` had an `_Engine&&` constructor but its base classes didn't, so it was always copying.
    @StephanTLavavej
    StephanTLavavej committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    a6fbc96 View commit details
    Browse the repository at this point in the history