ASAN found _two_ bugs in _Copy_vbool!
#4045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `_IsSingleBlockDest` wasn't accounting for the fact that `_DestEnd` is past-the-end * we sometimes don't realize we're done and read past the end of the input
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Sep 22, 2023
StephanTLavavej
requested changes
Sep 22, 2023
StephanTLavavej
approved these changes
Sep 22, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for finding and fixing these bugs so fast! 🕵️ 🔍 🛠️ |
miscco
reviewed
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_IsSingleBlockDestwasn't accounting for the fact that_DestEndis past-the-endTest coverage is forthcoming in my ASAN work. (I've run 1e7 iterations of the randomized test locally, FWIW.)