Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<utility>
formake_index_sequence
.bool
underlying types when we callto_underlying()
later.Mdspan
=>mdspan
in comments.array
froms
toa
.ActionTracker
observers as[[nodiscard]]
.M1
typedef. Renamem2
=>m1
to avoid looking weird.Mapping
typedef, like the block immediately above, and thelayout_right
test.LyingLayout
inherits fromlayout_left::mapping<Extents>
; use that foris_always_exhaustive()
.span<int>
is inherently symmetry-breaking here.layout_stride::mapping
without an extraspan
, matchingP0009R18_mdspan_layout_right
.P0009R18_mdspan_layout_right
,check_construction_from_other_right_mapping()
was missing "Check effects", whilecheck_construction_from_other_left_mapping()
was testinglayout_right::mapping
as the source.noexcept
.test_construction_from_[span/array]_with_invalid_values()
:other.extent(r)
=>exts[r]
test_construction_from_span_with_unrepresentable_as_index_type_values()
andtest_construction_from_array_with_invalid_values()
were tangled up.