Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final mdspan test fixes #3954

Conversation

StephanTLavavej
Copy link
Member

  • Include <utility> for make_index_sequence.
  • Use bool underlying types when we call to_underlying() later.
  • Mdspan => mdspan in comments.
  • Rename an array from s to a.
    • The nearby comment is intentionally unchanged.
  • Mark ActionTracker observers as [[nodiscard]].
  • Use M1 typedef. Rename m2 => m1 to avoid looking weird.
  • Extract Mapping typedef, like the block immediately above, and the layout_right test.
  • LyingLayout inherits from layout_left::mapping<Extents>; use that for is_always_exhaustive().
  • Drop repeated line; span<int> is inherently symmetry-breaking here.
  • Construct layout_stride::mapping without an extra span, matching P0009R18_mdspan_layout_right.
  • In P0009R18_mdspan_layout_right, check_construction_from_other_right_mapping() was missing "Check effects", while check_construction_from_other_left_mapping() was testing layout_right::mapping as the source.
  • Test how comparisons are guaranteed to be noexcept.
  • Fix tangled tests in P0009R18_mdspan_extents_death.
    • Fix comments for test_construction_from_[span/array]_with_invalid_values(): other.extent(r) => exts[r]
    • test_construction_from_span_with_unrepresentable_as_index_type_values() and test_construction_from_array_with_invalid_values() were tangled up.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
The nearby comment is intentionally unchanged.
…ht_mapping()` was missing "Check effects", while `check_construction_from_other_left_mapping()` was testing `layout_right::mapping` as the source.
Fix comments for `test_construction_from_[span/array]_with_invalid_values()`: `other.extent(r)` => `exts[r]`

`test_construction_from_span_with_unrepresentable_as_index_type_values()` and `test_construction_from_array_with_invalid_values()` were tangled up.
@StephanTLavavej StephanTLavavej added test Related to test code mdspan C++23 mdspan labels Aug 12, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner August 12, 2023 03:25
@StephanTLavavej StephanTLavavej merged commit 425317d into microsoft:feature/mdspan2 Aug 12, 2023
@StephanTLavavej StephanTLavavej deleted the final-mdspan-test-fixes branch August 12, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mdspan C++23 mdspan test Related to test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant