Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update preprocessor #else and #endif comment #3950

Merged
merged 24 commits into from
Sep 21, 2023

Conversation

AlexGuteniev
Copy link
Contributor

More towards #351. Product files (non-test).

Skipped in the previous #3900

  • && / ||, de-morganed
  • lone #endif, not specifically targeted in the previous PR
  • yals_core.h / yvals.h macro introduction
  • #elif-containing blocks
  • Missed for some other reasons

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner August 11, 2023 07:42
@StephanTLavavej StephanTLavavej added the documentation Related to documentation or comments label Aug 11, 2023
@StephanTLavavej StephanTLavavej self-assigned this Aug 14, 2023
@StephanTLavavej
Copy link
Member

I've pushed a merge with main to resolve a simple conflict with #4000, then a whole bunch of changes for issues identified during code review (a few were pre-existing cleanups that fit with this PR):

  • Add missing defined.
  • Restore lost underscores.
  • Add missing arrow, replace complex De Morgan with matching comment.
  • Fix whitespace.
  • Use proper arrow comments.
  • Simply drop a horribly long comment, using our convention that we can omit them in single-line, non-nested contexts.
  • Too many arrows.
  • Use systematic _HAS_CXX17 comments.
  • Use systematic _HAS_CXX20 comments.
  • Use matching arrow comments.
  • Simplify calling convention comments, omit pre-existing newlines.
  • Fix comments around extended aligned storage.
  • Drop spurious !.
  • Add missing !.
  • Fix damaged !!, use matching "floating-point exceptions disabled (default)" comment.
  • Fix FBITS comments.

@StephanTLavavej
Copy link
Member

These comment changes aren't risky; we can merge them without a second maintainer approval.

@StephanTLavavej StephanTLavavej self-assigned this Sep 20, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 939513b into microsoft:main Sep 21, 2023
35 checks passed
@StephanTLavavej
Copy link
Member

Thanks again for improving codebase consistency! 📜 📄 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation or comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants