Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdspan STL's review comments - easy part #3944

Merged
merged 1 commit into from
Aug 10, 2023
Merged

mdspan STL's review comments - easy part #3944

merged 1 commit into from
Aug 10, 2023

Conversation

AlexGuteniev
Copy link
Contributor

  • Remove superfluous std::, the tests do using namespace std;
  • Cast bool to size_t explicitly
  • Check the correct constructor

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner August 10, 2023 15:46
@CaseyCarter CaseyCarter added the mdspan C++23 mdspan label Aug 10, 2023
@StephanTLavavej StephanTLavavej merged commit 74e82a6 into microsoft:feature/mdspan2 Aug 10, 2023
@StephanTLavavej
Copy link
Member

Thanks for fixing these issues! 😻

@AlexGuteniev AlexGuteniev deleted the feature/mdspan2 branch August 10, 2023 18:54
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees
No one assigned
Labels
mdspan C++23 mdspan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexGuteniev @StephanTLavavej @CaseyCarter