Code

Logic cleanups for basic_string#3862

Code

Merged

StephanTLavavej merged 26 commits intomicrosoft:mainmicrosoft/STL:mainfrom achabense:_String_logic_cleanupsachabense/STL:_String_logic_cleanupsCopy head branch name to clipboardAug 11, 2023

+172-168

Commits

Commits on Jul 27, 2023

• Make string(const T*) and string(const T*, const Alloc&) adjacent

  

  achabense

  authored and

  StephanTLavavej

  committed
  45e738d

  Copy full SHA for 45e738d

• Add _NODISCARD for _String_val methods

  

  achabense

  authored and

  StephanTLavavej

  committed
  9f726f9

  Copy full SHA for 9f726f9

• make _Activate_SSO_buffer _CONSTEXPR20

  

  achabense

  authored and

  StephanTLavavej

  committed
  02b90ed

  Copy full SHA for 02b90ed

• Make types of _BUF_SIZE and _ALLOC_MASK clear

  

  achabense

  authored and

  StephanTLavavej

  committed
  ca0953a

  Copy full SHA for ca0953a

• Introduce _SMALL_STRING_CAPACITY; replace _BUF_SIZE - 1 with it

  

  achabense

  authored and

  StephanTLavavej

  committed
  ef708ed

  Copy full SHA for ef708ed

• Refine _Large_string_engaged; find a missed usecase for it

  

  achabense

  authored and

  StephanTLavavej

  committed
  d3f736b

  Copy full SHA for d3f736b

• Introduce _Entails_large_string; replace wild _Large_string_engaged logic with it

  

  achabense

  authored and

  StephanTLavavej

  committed
  e1ce499

  Copy full SHA for e1ce499

• Replace capacity-decision logic with _Entails_large_string

  

  achabense

  authored and

  StephanTLavavej

  committed
  e050101

  Copy full SHA for e050101

• Refine documentation of interaction part with basic_stringbuf

  

  achabense

  authored and

  StephanTLavavej

  committed
  2b966c6

  Copy full SHA for 2b966c6

• Try to improve documentation for _Mysize and _Myres

  

  achabense

  authored and

  StephanTLavavej

  committed
  d0c9dfc

  Copy full SHA for d0c9dfc

Commits on Jul 28, 2023

• Replace two autos with explicit types.

  

  achabense

  authored and

  StephanTLavavej

  committed
  cb010d7

  Copy full SHA for cb010d7

• Introduce _Allocate_for_capacity and _Deallocate_for_capacity and apply them wherever suitable; merge _Start_element_lifetimes into _Allocate_for_capacity

  

  achabense

  authored and

  StephanTLavavej

  committed
  28c834e

  Copy full SHA for 28c834e

• Fix a misuse of _Large_string_engaged (which will otherwise break the invariant that string won't do allocations for small capacity)

  

  achabense

  authored and

  StephanTLavavej

  committed
  5ba8339

  Copy full SHA for 5ba8339

• Serially run the tests in Dev09_181509_tr1_inf_loop_uniform_int_ull.

  StephanTLavavej

  committed
  9b729de

  Copy full SHA for 9b729de

• Fix comment grammar.

  StephanTLavavej

  committed
  2b017db

  Copy full SHA for 2b017db

• In _Deallocate_for_capacity, pass _Old_ptr by value.

  StephanTLavavej

  committed
  e600d39

  Copy full SHA for e600d39

• Drop redundant public: after the removal of _Copy_assign_val_from_small.

  StephanTLavavej

  committed
  6f8a3cb

  Copy full SHA for 6f8a3cb

• Add test_string_copy_assign_pocca_sso().

  StephanTLavavej

  committed
  0baefec

  Copy full SHA for 0baefec

• Restore shrink_to_fit to allocate exactly.

  StephanTLavavej

  committed
  9b0e590

  Copy full SHA for 9b0e590

• _Reallocation_policy => _Allocation_policy

  StephanTLavavej

  committed
  3a27c90

  Copy full SHA for 3a27c90

Commits on Aug 9, 2023

• Rename to avoid macro identifier space

  Show description for 6ea7f29
  CaseyCarter

  committed
  6ea7f29

  Copy full SHA for 6ea7f29

• Rename _Large_string_engaged to _Large_mode_engaged

  Show description for a2cb72b
  CaseyCarter

  committed
  a2cb72b

  Copy full SHA for a2cb72b

• Expand _Entails_large_string into callsites

  Show description for 9921deb
  CaseyCarter

  committed
  9921deb

  Copy full SHA for 9921deb

• "small mode" instead of "SSO mode"

  Show description for 84b8ced
  CaseyCarter

  committed
  84b8ced

  Copy full SHA for 84b8ced

• Rename _Buf_res and _Released_buffer::_Res

  Show description for 9ed46dc
  CaseyCarter

  committed
  9ed46dc

  Copy full SHA for 9ed46dc

• Don't enumerate users of _Least_allocation_size

  Show description for e2ac4ce
  CaseyCarter

  committed
  e2ac4ce

  Copy full SHA for e2ac4ce