-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add specialization for 24MHz QueryPerformanceFrequency #3832
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f7479ab
add specialization for 24MHz QueryPerformanceFrequency
fsb4000 2877870
remove likely and unlikely
fsb4000 b4557d4
restore likely/unlikely logic
fsb4000 9b32bef
code review suggestions
fsb4000 5b995f0
remove _STL_ prefix
fsb4000 0829dfa
typo
fsb4000 d4e3b49
refactor
fsb4000 92d37c7
Code review feedback.
StephanTLavavej d9d5de1
Restore emulation comment.
StephanTLavavej File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to do the
push_macro/undef/pop_macro
magic incantation here forlikely
andunlikely
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likely
andunlikely
are commonly defined as function-like macros, but not object-like macros.<xkeycheck.h>
avoids rejecting them for that reason.Unlike
msvc
etc., users are technically not supposed to macroizelikely
andunlikely
, so we technically don't need to defend against them. We could but I don't think it's necessary at the moment.