Implement signature changes for char_traits in N2349
#3739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also test that `int_type` are implemented as specified by the standard
StephanTLavavej
approved these changes
May 28, 2023
strega-nil-ms
approved these changes
Jun 14, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
CaseyCarter
approved these changes
Jun 14, 2023
|
I've pushed a merge with |
|
Thanks to @achabense and you for noticing and fixing this conformance issue! 🎉 👀 🎯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions are inline and will have different mangled names if their signatures get changed, so I think the changes are not ABI-breaking.
I've filed LWG-3942 for remain
const char_type&occurences inchar_traits- IMO they should all be replaced with plainchar_type.Also test that member type aliases
int_typeare implemented as specified by the standard.Fixes #3735.