Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<format>: Restore the indent after adding inline namespace __p2286 #3726

Merged
merged 1 commit into from
May 31, 2023
Merged

<format>: Restore the indent after adding inline namespace __p2286 #3726

merged 1 commit into from
May 31, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

Also avoid writing the #if _HAS_CXX23-#endif pair in several places.

@frederick-vs-ja
Restore indent after adding inline namespace __p2286
c26636b 
Also avoid `#if _HAS_CXX23`/`#endif` in several places.
@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner May 21, 2023 13:58
@CaseyCarter CaseyCarter added the enhancement Something can be improved label May 24, 2023
@StephanTLavavej StephanTLavavej added the format C++20/23 format label May 25, 2023
@StephanTLavavej StephanTLavavej self-assigned this May 26, 2023
@StephanTLavavej
Copy link
Member

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@cpplearner cpplearner mentioned this pull request May 27, 2023
Merged
@StephanTLavavej StephanTLavavej merged commit a8c4737 into microsoft:main May 31, 2023
@StephanTLavavej
Copy link
Member

Thanks for this formatting improvement! 😸 ✨ 🎉

@frederick-vs-ja frederick-vs-ja deleted the __p2286 branch May 31, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved format C++20/23 format
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frederick-vs-ja @StephanTLavavej @CaseyCarter