remove operator>> for istream >> setfill(c)
#3725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/std/tests/VSO_0000000_instantiate_iterators_misc/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
May 25, 2023
CaseyCarter
approved these changes
May 26, 2023
| } | ||
|
|
||
| template <typename IoManip> | ||
| void iomanip_test_impl(IoManip iom) { | ||
| iomanip_test_impl(iom, iom); | ||
| } | ||
|
|
||
| template <typename IoManip> | ||
| void iomanip_test_impl_for_setfill(IoManip out) { |
There was a problem hiding this comment.
It's a little weird that this generic function is used only with setfill and includes setfill in its name. I'd call this _output_only or something, describing what it does instead of how it's currently used. This isn't worth resetting testing, though, so don't bother if we don't need to touch something else.
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing this long-standing nonconformance! 🎉 😸 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3724