Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup elements when resize fails in deque(n) #3720

Merged
merged 1 commit into from
May 30, 2023
Merged

Cleanup elements when resize fails in deque(n) #3720

merged 1 commit into from
May 30, 2023

Conversation

CaseyCarter
Copy link
Member

Fixes #3717

@CaseyCarter CaseyCarter added the bug Something isn't working label May 19, 2023
@CaseyCarter CaseyCarter requested a review from a team as a code owner May 19, 2023 19:48
@StephanTLavavej StephanTLavavej self-assigned this May 26, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 15dd2ab into microsoft:main May 30, 2023
@StephanTLavavej
Copy link
Member

Thanks for fixing this major bug in the STL's most important container! 😹 🐞 🎉

@CaseyCarter CaseyCarter deleted the deque_leak branch May 31, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deque(size_t,const Allocator&) doesn't clear up constructed elements on exception
3 participants
@CaseyCarter @StephanTLavavej @strega-nil-ms