Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<mdspan>: Diversify integer types used in tests #3682

Merged
merged 5 commits into from
May 11, 2023
Merged

<mdspan>: Diversify integer types used in tests #3682

merged 5 commits into from
May 11, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented May 4, 2023 •
edited
Loading

  • Improve tests of extents and layout mappings:
    • Check all 10 standard signed and unsigned integer types,
    • Check various combinations of static and dynamic extents.
  • Fix integral conversions in layout_stride::mapping.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner May 4, 2023 16:17
@CaseyCarter CaseyCarter added test Related to test code mdspan C++23 mdspan labels May 4, 2023
@StephanTLavavej StephanTLavavej self-assigned this May 5, 2023
StephanTLavavej
StephanTLavavej reviewed May 11, 2023
View reviewed changes
tests/std/include/test_mdspan_support.hpp Outdated Show resolved Hide resolved
tests/std/include/test_mdspan_support.hpp Outdated Show resolved Hide resolved
tests/std/include/test_mdspan_support.hpp Outdated Show resolved Hide resolved
tests/std/tests/P0009R18_mdspan_layout_stride/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0009R18_mdspan_layout_stride/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

I pushed minor style nitpicks and will merge after the tests pass. Thanks!

@StephanTLavavej StephanTLavavej merged commit 2bb397c into microsoft:feature/mdspan2 May 11, 2023
@JMazurkiewicz JMazurkiewicz deleted the mdspan/exhaustive-tests branch May 11, 2023 07:52
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattStephanson MattStephanson MattStephanson left review comments

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
mdspan C++23 mdspan test Related to test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JMazurkiewicz @StephanTLavavej @MattStephanson @CaseyCarter