<mdspan>: layout_stride improvements
#3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JMazurkiewicz
commented
Apr 26, 2023
JMazurkiewicz
commented
- Implement WG21-P2763R1,
- Implement preconditions (currently unconditional),
- Implement (incomplete) regular tests and death tests.
StephanTLavavej
approved these changes
Apr 26, 2023
| // Tests of 'is_exhaustive' are defined in 'check_is_exhaustive' function [FIXME] | ||
| } | ||
|
|
||
| { // Check 'stride' function (intentionally not if constexpr) |
There was a problem hiding this comment.
I'm confused by "(intentionally not if constexpr)" here - I don't see any if at all?
There was a problem hiding this comment.
if statement used to be here, I forgot to fix the comment
|
|
||
| template <class IndexType, size_t... Extents, size_t... Indices> | ||
| constexpr void do_check_members(const extents<IndexType, Extents...>& ext, | ||
| const array<IndexType, sizeof...(Extents)> strs, index_sequence<Indices...>) { |
There was a problem hiding this comment.
Suggestion: I would usually expect array to be passed by const reference, not by const value, although this doesn't affect test correctness or lead to test instability. Occurs below.
|
Just a small question and suggestion, but I went ahead and merged this - thank you! 😻 🚀 ✅ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.