Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<mdspan>: Add _EXPORT_STD, tiny cleanups #3563

Merged
merged 3 commits into from
Mar 13, 2023
Merged

<mdspan>: Add _EXPORT_STD, tiny cleanups #3563

merged 3 commits into from
Mar 13, 2023

Conversation

StephanTLavavej
Copy link
Member

  • Drop _STD qualification for make_index_sequence.
  • Remove dead _Multiply(). Also, _X and _Y were macro-like.
  • All shall love _EXPORT_STD and despair. 🧝‍♀️

@StephanTLavavej StephanTLavavej added modules C++23 modules, C++20 header units mdspan C++23 mdspan labels Mar 12, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner March 12, 2023 21:57
@StephanTLavavej StephanTLavavej merged commit 5c2e59b into microsoft:feature/mdspan2 Mar 13, 2023
@StephanTLavavej StephanTLavavej deleted the export-mdspan branch March 13, 2023 03:26
@frederick-vs-ja
Copy link
Contributor

This PR placed occurences of _EXPORT_STD in separated lines, while _EXPORT_STD is generally placed in the same line of template or struct. Is this intended?

JMazurkiewicz
JMazurkiewicz reviewed Mar 13, 2023
View reviewed changes
stl/inc/mdspan
@@ -117,6 +117,7 @@ struct _Mdspan_extent_type<_IndexType, 0> {
}
};

_EXPORT_STD
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz Mar 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test in tests/std/include/test_header_units_and_modules.hpp for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, once I learn how to use <mdspan> in a basic way 😹 Added to my todo list if nobody else gets to it first, thanks.

@StephanTLavavej
Copy link
Member Author

@frederick-vs-ja Huh, thanks for noticing I did that. It wasn't intentional, added to my todo list to fix.

JMazurkiewicz added a commit to JMazurkiewicz/STL that referenced this pull request Mar 25, 2023
@JMazurkiewicz
Fix _EXPORT_STD
1ef432a 
Addresses microsoft#3563 (comment)
JMazurkiewicz added a commit to JMazurkiewicz/STL that referenced this pull request Mar 25, 2023
@JMazurkiewicz
Fix _EXPORT_STD
1815bc6 
Addresses microsoft#3563 (comment)
@JMazurkiewicz JMazurkiewicz mentioned this pull request May 10, 2023
Merged
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMazurkiewicz JMazurkiewicz JMazurkiewicz left review comments

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees
No one assigned
Labels
mdspan C++23 mdspan modules C++23 modules, C++20 header units
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StephanTLavavej @frederick-vs-ja @CaseyCarter @JMazurkiewicz